Some improvements to the way we allocate and track snapshot ids - #784
Open
Julian Gutierrez Oschmann (juli4n) wants to merge 1 commit into
Open
Some improvements to the way we allocate and track snapshot ids#784Julian Gutierrez Oschmann (juli4n) wants to merge 1 commit into
Julian Gutierrez Oschmann (juli4n) wants to merge 1 commit into
Conversation
Julian Gutierrez Oschmann (juli4n)
changed the title
Julian Gutierrez Oschmann (juli4n)
force-pushed
the
snapshot_ids
branch
3 times, most recently
from
August 6, 2026 20:19
eb89114 to
3030f69
Compare
…ids. * Consolidate snapshot id and name into a single concept. * Use consistent terminology across the whole stack (i.e. remove confusion about prefix vs id vs name). * Get rid of internal only storage to hide the snapshot URI.
Julian Gutierrez Oschmann (juli4n)
force-pushed
the
snapshot_ids
branch
from
August 7, 2026 16:00
3030f69 to
1ff1491
Compare
Julian Gutierrez Oschmann (juli4n)
requested a review
from Eitan Yarmush (EItanya)
August 7, 2026 16:03
Julian Gutierrez Oschmann (juli4n)
marked this pull request as ready for review
August 7, 2026 16:03
Eitan Yarmush (EItanya)
approved these changes
Aug 7, 2026
Comment on lines
+33
to
+44
| // SnapshotURI is where one ActorSnapshot's objects live in object storage: | ||
| // an ActorTemplate's snapshotsConfig.location, plus /snapshots/<atespace>/<name>. | ||
| // | ||
| // gs://bucket/root location | ||
| // gs://bucket/root/snapshots/team-a/<name> this URI | ||
| // gs://bucket/root/snapshots/team-a/<name>/... an object in the snapshot | ||
| type SnapshotURI struct { | ||
| uri string | ||
| location string | ||
| atespace string | ||
| name string | ||
| } |
Collaborator
There was a problem hiding this comment.
I see that this is moving the snapshot back into an atespaced key. I specifically undid this in my PR to ensure that later tags could be made global, or potentially move between atespaces without confusion. However, given that we made tags atespaced I think it should be safe to go back to this. The only thing I'll mention is the situation where we want to copy tags to specific atespaces, if the snapshots are atespaced we'd probably need to copy the data
Comment on lines
+583
to
+584
| // The store round-trips the whole resource, snapshot_uri included: it is | ||
| // an ordinary field now, not a value the store keeps beside the record. |
Collaborator
There was a problem hiding this comment.
Just FWIW on this, the reason was to hide the storage internals from the snapshot resource itself, and users who have access to it. But in hindsight that might've been unnecessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #773
Some improvements to the way we create, track and propagate snapshot ids.